Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ampdoc-fie in AmpDoc service #30511

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Cleanup ampdoc-fie in AmpDoc service #30511

merged 5 commits into from
Oct 6, 2020

Conversation

dvoytenko
Copy link
Contributor

Partial for #22733.

@google-cla google-cla bot added the cla: yes label Oct 4, 2020
@dvoytenko dvoytenko marked this pull request as ready for review October 5, 2020 23:55
@dvoytenko dvoytenko merged commit 30b35e7 into ampproject:master Oct 6, 2020
@dvoytenko dvoytenko deleted the ampdocfie/cleanup_try_ampdoc branch October 6, 2020 23:05
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@ed-bird
Cleanup ampdoc-fie in AmpDoc service (ampproject#30511)
b73bcbf 
* Cleanup ampdoc-fie in AmpDoc service

* fixed some tests

* ampdoc tests fixed

* fix canary flag in test-3p-frame

* remove old code
@ampprojectbot ampprojectbot mentioned this pull request Jan 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoytenko @calebcordry @ampprojectbot